Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Options argument from required to optional #132

Merged
merged 1 commit into from
Nov 4, 2022
Merged

fix: Options argument from required to optional #132

merged 1 commit into from
Nov 4, 2022

Conversation

yoshinorin
Copy link
Member

As is the title.

What is a problem?

Current v4.0.0 must be pass a Options argument when call logger.
IMHO Options should be optional.

Thank you.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.413% when pulling c9e411c on fix/optional into d023800 on master.

@yoshinorin yoshinorin mentioned this pull request Nov 4, 2022
Merged
@yoshinorin yoshinorin merged commit 42b66e6 into master Nov 4, 2022
@yoshinorin yoshinorin deleted the fix/optional branch November 4, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yoshinorin @coveralls @SukkaW